BIND 10 #2372: define State class for MasterLexer, base part

BIND 10 Development do-not-reply at isc.org
Tue Nov 13 13:46:04 UTC 2012


#2372: define State class for MasterLexer, base part
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20121120
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  libdns++                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  6
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
  loadzone-ng                        |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => jinmei


Comment:

 Hello

 Replying to [comment:9 jinmei]:
 > As far as I can see the only exception is `String::handle()`, which is
 > currently incomplete and only used in tests in an incomplete way.
 > This will be completed in #2373.
 >
 > It would be better if we can make it sure in the code flow (i.e,
 > ensuring token is always set if handle() returns NULL), but I don't
 > have a good idea on how to do it.

 I see an option. The start could set the token to something specific at
 its
 start. Then when the getToken looks for the token, it could detect it was
 not
 set to something else.

 Or, I can do all this in the #2375 inside getNextToken(). That sounds
 cleaner,
 so I think this branch can be merged.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2372#comment:11>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list