BIND 10 #2472: Integrate MySQL Backend into DHCPv6 Server

[BIND 10 Development]

#2472: Integrate MySQL Backend into DHCPv6 Server
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  stephen
  stephen                            |                Status:  reviewing
                       Type:  task   |             Milestone:  Sprint-
                   Priority:  high   |  DHCP-20121115
                  Component:  dhcp6  |            Resolution:
                   Keywords:         |             Sensitive:  0
            Defect Severity:  N/A    |           Sub-Project:  DHCP
Feature Depending on Ticket:         |  Estimated Difficulty:  0
        Add Hours to Ticket:  0      |           Total Hours:  0
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by marcin):

 * owner:  marcin => stephen
 * status:  assigned => reviewing


Comment:

 '''memfile_lease_mgr.h'''
 There is inconsistency between various methods in Memfile_LeaseMgr with
 respect to use of the ''virtual'' keyword: some  methods have this
 keyword, other methods don't.

 What is the purpose of the ''using'' declaration:
 {{{
 using LeaseMgr::getParameter
 }}}
 ?
 It can be used to change the scope of the member from protected to public
 but this method is already in public scope in the parent class.

 '''memfile_lease_mgr_unittest.cc'''
 GetTypeAndName: I believe that most of the BIND10 unit test name start
 with lower case.


 '''mysql_lease_mgr_unittest.cc'''
 GetType: same as a above

 General suggestion: I think it is a good practice to put a brief
 description of the test's purpose. We don't follow this in many tests but
 we could at least do it for new tests. You have added two unit tests, I
 suggest that you add brief description.



 '''memfile_lease_mgr.cc'''
 There are multiple methods with empty body. I suggest that their
 implementation is moved to header file as it will improve code's
 readability.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2472#comment:3>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development