BIND 10 #2468: b10-stats-httpd_test.py not stopping

BIND 10 Development do-not-reply at isc.org
Wed Nov 14 03:26:55 UTC 2012


#2468: b10-stats-httpd_test.py not stopping
-------------------------------------+-------------------------------------
                   Reporter:  jreed  |                 Owner:
                       Type:         |                Status:  new
  defect                             |             Milestone:  New Tasks
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:         |           Sub-Project:  Core
  statistics                         |  Estimated Difficulty:  0
                   Keywords:         |           Total Hours:  0
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:5 naokikambe]:
 > Thank you for committing. But the new code seems to open more files than
 before (The new code seems to need more msgq sockets). To improve this
 issue, I've now pushed a new branch as trac2468. By this improvement,
 extra stats servers wasn't started. So even if setting ``ulimit -n 256``,
 revised ``b10-stats-httpd_test.py`` doesn't fail on my environment. Could
 you try the branch?

 If the server instance is only needed for that specific test, the
 change itself may make sense, but I don't understand why the original
 code requires too many open files, and I'm a bit reluctant to give it
 a go without knowing why it solves the problem.

 I'd be also concerned about the use of a separate thread for unit
 tests in the first place.  Sometimes such a tricky setup might be the
 real last resort, but we should at least fully consider other options
 with some proper abstraction of the service.  It's often possible for
 such a dynamic language as Python.

 Regarding the code itself, the use of hasattr seems to be a bit
 cryptic.  While we need more lines of code, it seems to me more
 natural if we set it to None in setUp() and do shutdown if it is not
 None in tearDown.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2468#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list