BIND 10 #2468: b10-stats-httpd_test.py not stopping

BIND 10 Development do-not-reply at isc.org
Wed Nov 14 11:52:59 UTC 2012


#2468: b10-stats-httpd_test.py not stopping
-------------------------------------+-------------------------------------
                   Reporter:  jreed  |                 Owner:
                       Type:         |                Status:  new
  defect                             |             Milestone:  New Tasks
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:         |           Sub-Project:  Core
  statistics                         |  Estimated Difficulty:  0
                   Keywords:         |           Total Hours:  0
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by naokikambe):

 Replying to [comment:8 jinmei]:
 I'm ok with either merging or reverting.

 BTW on the current master, if I set limit -n 256 and disabled all test
 classes other than ``!TestStatsHttpd`` like the following, it passed (no
 "Too many open files" error happened). So probably python might do
 multiple unittests at a time.

 If some tests take some time (or finishing some tests take some time), the
 number of opened files might be increased in a short time. Of course,
 unless the test uses threads, the number wouldn't be increased so
 sharply:).

 {{{#!patch
 diff --git a/src/bin/stats/tests/b10-stats-httpd_test.py
 b/src/bin/stats/tests/b10-stats-httpd_test.py
 index 997ac41..7be2a82 100644
 --- a/src/bin/stats/tests/b10-stats-httpd_test.py
 +++ b/src/bin/stats/tests/b10-stats-httpd_test.py
 @@ -145,6 +145,7 @@ def is_ipv6_enabled(address='::1', port=8001):
              if sock: sock.close()
      return False

 + at unittest.skip
  class TestItemNameList(unittest.TestCase):

      def test_item_name_list(self):
 @@ -223,6 +224,7 @@ class TestItemNameList(unittest.TestCase):
          self.assertEqual(ans,
                           stats_httpd.item_name_list(dictlist, ''))

 + at unittest.skip
  class TestHttpHandler(unittest.TestCase):
      """Tests for HttpHandler class"""
      def setUp(self):
 @@ -550,6 +552,7 @@ class TestHttpHandler(unittest.TestCase):
              # do validation
              self.assertTrue(xsd.validate(xml_doc))

 + at unittest.skip
  class TestHttpServerError(unittest.TestCase):
      """Tests for HttpServerError exception"""
      def test_raises(self):
 @@ -558,6 +561,7 @@ class TestHttpServerError(unittest.TestCase):
          except stats_httpd.HttpServerError as err:
              self.assertEqual(str(err), 'Nothing')

 + at unittest.skip
  class TestHttpServer(unittest.TestCase):
      """Tests for HttpServer class"""
      def setUp(self):
 @@ -579,6 +583,7 @@ class TestHttpServer(unittest.TestCase):
          for httpd in self.stats_httpd.httpd:
              self.assertTrue(isinstance(httpd, stats_httpd.HttpServer))

 + at unittest.skip
  class TestStatsHttpdError(unittest.TestCase):
      """Tests for StatsHttpdError exception"""
 }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/2468#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list