BIND 10 #2375: implement MasterLexer getNextToken() and ungetToken()

BIND 10 Development do-not-reply at isc.org
Wed Nov 14 13:28:08 UTC 2012


#2375: implement MasterLexer getNextToken() and ungetToken()
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  UnAssigned
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20121120
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  libdns++                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  5
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
  loadzone-ng                        |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => UnAssigned
 * status:  accepted => reviewing


Comment:

 Hello

 It is ready for review. There are some things I'd like to note:
  * I rebased the branch few times during the development. It should not be
 a
    problem, since nobody should have the branch checked out, but in case
    anybody does, please reset to the newest version.
  * I combine testing with mock states and the real states as they are
 implemented now.
  * It is not possible to unget a token every time. It is not possible
 after
    switching the sources and it is possible to go only one token back. It
 looks
    like this might be very similar to bind9 implementation.
  * The `getNextToken` provides only weak exception guarantee, but the only
    thing that is changed in case it is called and throws is it is no
 longer
    possible to unget the previous token. That should be OK in practice,
 because
    when someone calls the getNextToken, he wouldn't want to unget the
 previous
    one already.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2375#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list