BIND 10 #2421: don't reject configuring entire inmemory datasrc due to one broken zone

BIND 10 Development do-not-reply at isc.org
Thu Nov 15 07:57:29 UTC 2012


#2421: don't reject configuring entire inmemory datasrc due to one broken zone
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  vorner
  jinmei                             |                Status:  reviewing
                       Type:         |             Milestone:
  defect                             |  Sprint-20121120
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:  data   |           Sub-Project:  DNS
  source                             |  Estimated Difficulty:  4
                   Keywords:         |           Total Hours:  0
            Defect Severity:  High   |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by muks):

 * owner:  muks => vorner


Comment:

 Hi Michal

 Replying to [comment:12 vorner]:
 > The reasons to have unit test as well as unit ones are two:
 >  * Developers usually run unit tests only, not the lettuce tests, during
 >    development. I suspect not everybody runs lettuce test at least when
 >    submitting the ticket to review. So unit tests find the problem
 sooner.
 >  * When there's a problem, the unit test has smaller scope, so it points
 closer
 >    to the problem.

 That is good enough of a reason. :) I've added unit tests.

 > Also, this description:
 > {{{
 > % DATASRC_LOAD_FROM_ITERATOR_ERROR %1
 > An error was found in the zone data when it was being loaded from an
 > iterator. The zone was not loaded. The specific error is shown in the
 > message, and should be addressed.
 > }}}
 >
 > I don't know if the user knows enough of the internal to have clue what
 the iterator is. May I suggest to say something like „when it was being
 loaded from another data source“ or „from database“ or something like
 that?

 Updated.

 > Also, thinking about it, it might be useful to also log which zone it is
 (in both cases).

 Done.

-- 
Ticket URL: <https://bind10.isc.org/ticket/2421#comment:15>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list