BIND 10 #2373: MasterLexer's String/QuotedString state classes

[BIND 10 Development]

#2373: MasterLexer's String/QuotedString state classes
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20121120
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  libdns++                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  4
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
  loadzone-ng                        |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  UnAssigned => jinmei


Comment:

 Looks good, a few minor comments:

 master_lexer.cc:

 not entirely about this specific ticket, but in State::start() (line
 268+), any particular reason that big if-statement is not a switch?

 master_lexer_state_unittest.cc:

 for completeness, i'd add one final getToken() at the end of the
 stringEscape test, just to make sure the escaped escape doesn't somehow
 eat the rest of the input line or something (the last token 'backslash'
 isn't checked)
 {{{
     EXPECT_EQ(&s_string, State::start(lexer, common_options));
     EXPECT_EQ(s_null, s_string.handle(lexer)); // recognize str, see ' '
 in end
     stringTokenCheck("backslash", s_string.getToken(lexer));
 }}}

 Oh and it looks like some characters that are normally token separators
 aren't tested in quoted strings (like \t and parentheses)

-- 
Ticket URL: <http://bind10.isc.org/ticket/2373#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development