BIND 10 #2376: define LoaderContext class

[BIND 10 Development]

#2376: define LoaderContext class
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20121120
  medium                             |            Resolution:
                  Component:  data   |             Sensitive:  0
  source                             |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  4
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
  scalable inmemory                  |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 '''general'''

 As I already said, I would like to separate the error callbacks and
 the add callback.  The former will be passed to rdata constructors,
 and it would look awkward if it contained something related to
 `RRset`.

 '''datasrc_messages.mes'''
 - we should probably rename "CONTEXT" in DATASRC_LOAD_CONTEXT_xxx
   as we don't have an explicit context any more.  something like
   DATASRC_MASTER_LOAD_xxx.

 '''loader_callbacks.cc'''
 - a minor point: the policy of omitting 'isc::' is inconsistent.
 {{{#!cpp
 isc::dns::LoaderCallbacks
 createCallbacks(ZoneUpdater& updater, const dns::Name& name,
                 const dns::RRClass& rrclass, bool* ok)
 {
     return (isc::dns::LoaderCallbacks(boost::bind(&logError, name,
 rrclass, ok,
                                                   _1, _2, _3),
 }}}

 '''loader_callbacks_test'''

 - A minor point, but `LoaderContextTest` may be better named
   something like `LoaderCallbacksTest`.

 '''loader_callbacks_test'''

 - `addCall` test: I suspect it doesn't necessarily confirm that what
   was called is the add callback.  To make it sure we'd have a
   separate flag, e.g. add_called_ (but this comment could become moot
   depending on whether to include the add callback with issue ones.)

-- 
Ticket URL: <http://bind10.isc.org/ticket/2376#comment:17>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development