BIND 10 #2373: MasterLexer's String/QuotedString state classes

BIND 10 Development do-not-reply at isc.org
Mon Nov 19 11:10:09 UTC 2012


#2373: MasterLexer's String/QuotedString state classes
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20121120
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  libdns++                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  4
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
  loadzone-ng                        |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:8 jelte]:
 > OK, looks good. One test for the different separator chars seems fine to
 me.
 >
 > regarding the if-block; tbh I was thinking more about efficiency than
 readability, but I agree, let's take a look after 2374

 Ah, okay.  In my understanding large switch-case is not that efficient
 either, so if efficiency is a concern, I guess we need something more
 sophisticated.  Anyway, that's a post #2374 fodder.

 > This can be merged

 Okay, thanks, merge done, closing.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2373#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list