BIND 10 #2509: trailing comma in data_sources/classes/IN params list and zombie cfgmgr

[BIND 10 Development]

#2509: trailing comma in data_sources/classes/IN params list  and zombie cfgmgr
-------------------------------------+-------------------------------------
            Reporter:  jreed         |                        Owner:
                Type:  defect        |                       Status:  new
            Priority:  medium        |                    Milestone:  New
           Component:  Boss of BIND  |  Tasks
           Sensitive:  0             |                     Keywords:
         Sub-Project:  Core          |              Defect Severity:  N/A
Estimated Difficulty:  0             |  Feature Depending on Ticket:
         Total Hours:  0             |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
 I generated a list of data sources and my params had a trailing comma.
 This caused cfgmgr to become a defunct zombie (on Linux) process.

  no log message nor output.

 I only realized since bind10 every second does log  BIND10_WAIT_CFGMGR. I
 tested with different wait times.

 {{{
 2012-11-26 16:32:16.584 DEBUG [b10-boss.boss] BIND10_WAIT_CFGMGR waiting
 for configuration manager process to initialize
 2012-11-26 16:32:17.584 ERROR [b10-boss.boss]
 BIND10_COMPONENT_START_EXCEPTION component cfgmgr failed to start:
 Configuration manager process has not started
 2012-11-26 16:32:17.584 ERROR [b10-boss.boss] BIND10_COMPONENT_FAILED
 component cfgmgr (pid None) failed: unknown condition
 2012-11-26 16:32:17.584 FATAL [b10-boss.boss] BIND10_COMPONENT_UNSATISFIED
 component cfgmgr is required to run and failed
 2012-11-26 16:32:17.584 ERROR [b10-boss.boss]
 BIND10_CONFIGURATOR_PLAN_INTERRUPTED configurator plan interrupted, only 2
 of 3 done
 2012-11-26 16:32:17.584 INFO  [b10-boss.boss] BIND10_KILLING_ALL_PROCESSES
 killing all started processes
 }}}

 Here is an example:
 {{{
 {"version": 2,
 "Auth": {"listen_on": [{"port": 5300, "address": "127.0.0.1"}]},
 "Boss": {"components": {"b10-auth": {"kind": "needed", "special":
 "auth"}}},
 "data_sources": {"classes": {"IN": [{"params": {
 "1.example":
 "/home/jreed/test5-zones/1.example-canonical",
 "2.example":
 "/home/jreed/test5-zones/2.example-canonical",
 }, "type": "MasterFiles", "cache-enable": true}]}}}
 }}}


 I do get a message like:

 {{{
 2012-11-26 16:51:18.501 FATAL [b10-cfgmgr.cfgmgr] CFGMGR_DATA_READ_ERROR
 error reading configuration database from disk: Configuration file out of
 date or corrupt, please update or remove
 /home/jreed/dnsbench/work/origin/bind10-20121115-release/20121126190544/install/var/bind10-devel/b10-config.db
 }}}

 But that may be overlooked after many BIND10_WAIT_CFGMGR lines.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2509>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development