BIND 10 #2374: MasterLexer's Number state classes

[BIND 10 Development]

#2374: MasterLexer's Number state classes
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jelte
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20121204
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  libdns++                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  4
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
  loadzone-ng                        |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by muks):

 * owner:  muks => jelte


Comment:

 Maybe one more test can be added (which ends up getting parsed as a
 string):
 {{{
 diff --git a/src/lib/dns/tests/master_lexer_state_unittest.cc
 b/src/lib/dns/tests/master_lexer_state_unitt
 index 83ae7cb..a46bfb3 100644
 --- a/src/lib/dns/tests/master_lexer_state_unittest.cc
 +++ b/src/lib/dns/tests/master_lexer_state_unittest.cc
 @@ -526,6 +526,7 @@ TEST_F(MasterLexerStateTest, stringNumbers) {
                           // as strings (unsigned integers only)
      ss << "123abc456 ";  // 'Numbers' containing non-digits should
                           // be interpreted as strings
 +    ss << "123\\456 ";   // Numbers containing escaped digits are
 +                         // interpreted as strings
      ss << "3scaped\\ space ";
      ss << "3scaped\\\ttab ";
      ss << "3scaped\\(paren ";
 @@ -545,6 +546,10 @@ TEST_F(MasterLexerStateTest, stringNumbers) {
      stringTokenCheck("123abc456", s_number.getToken(lexer), false);

      EXPECT_EQ(&s_number, State::start(lexer, common_options));
 +    EXPECT_EQ(s_null, s_number.handle(lexer));
 +    stringTokenCheck("123\\456", s_number.getToken(lexer), false);
 +
 +    EXPECT_EQ(&s_number, State::start(lexer, common_options));
      EXPECT_EQ(s_null, s_number.handle(lexer)); // recognize str, see ' '
 at end
      stringTokenCheck("3scaped\\ space", s_number.getToken(lexer));
 }}}

 The rest looks good to me. Please go ahead and merge.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2374#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development