BIND 10 #2375: implement MasterLexer getNextToken() and ungetToken()

BIND 10 Development do-not-reply at isc.org
Tue Nov 27 18:34:45 UTC 2012


#2375: implement MasterLexer getNextToken() and ungetToken()
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  vorner
  jinmei                             |                Status:  closed
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20121204
  medium                             |            Resolution:  fixed
                  Component:         |             Sensitive:  0
  libdns++                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  5
            Defect Severity:  N/A    |           Total Hours:  10.73
Feature Depending on Ticket:         |
  loadzone-ng                        |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 I just noticed there was a few minor things I wanted to fix before
 merge.  It's too later, though, so I'll leave it to #2506.

 '''master_lexer.cc'''

 - a minor point: this comment (now?) seems to be incomplete:
 {{{#!cpp
     // If the source is not available
     if (impl_->source_ == NULL) {
         isc_throw(isc::InvalidOperation, "No source to read tokens from");
     }
 }}}

 '''master_lexer_state.h'''

 - this one is now obsolete (about returning NULL):
 {{{#!cpp
 /// When an object of a specific state class completes the session, it
 /// normally sets the identified token in the lexer, and returns NULL;
 /// if more transition is necessary, it returns a pointer to the next
 state
 /// object.
 }}}
   please make comprehensive check to detect and update all such cases,
   if any.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2375#comment:20>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list