BIND 10 #2312: Custom Option implementation

[BIND 10 Development]

#2312: Custom Option implementation
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  marcin
  marcin                             |                Status:  reviewing
                       Type:  task   |             Milestone:  Sprint-
                   Priority:         |  DHCP-20121129
  medium                             |            Resolution:
                  Component:  dhcp   |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DHCP
            Defect Severity:         |  Estimated Difficulty:  0
  Medium                             |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => marcin


Comment:

 >> '''src/lib/dhcp/option_custom.cc'''
 >> pack4()/pack6(): are we sure that an !OptionBuffer can't be empty? If
 it is, then the reference to (*it)[0] could be invalid.
 > In theory it shouldn't because it is being validated by createBuffers
 but ... I added a check to be sure.
 A check has been added for pack4() but not pack6().  As an aside, in
 general using "!container.empty()" is better than "container.size() > 0".
 It doesn't really make a difference for vectors, but for other STL
 containers, calculating size() can be a lengthy operation.

 Regarding the comment, I would suggest taking out the second sentence so
 that it reads:
 {{{
 XXX.    [func]          marcin
         Implemented the OptionCustom class for DHCPv4 and DHCPv6.
         This class represents an option which has a defined
         structure: a set of data fields of specific types and order.
         It is used to represent those options that can't be
         represented by any other specialized class.
         (Trac #2312, git ...)
 }}}
 (The !ChangeLog entry does have to describe how to use the class.)

 I don't need to see this again - merge when ready.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2312#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development