BIND 10 #2157: Create an interface to pass statistics counters in Auth module

[BIND 10 Development]

#2157: Create an interface to pass statistics counters in Auth module
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  y-aharen                           |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20121204
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:         |           Sub-Project:  DNS
  b10-auth                           |  Estimated Difficulty:  8
                   Keywords:         |           Total Hours:  0
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 '''auth_srv_unittest.cc'''

 - Generally, added tests look pretty good, but it repeats the same
   pattern of code many times.  In particular, since the condition of
   the initial counters are the same (in most if not all cases), I
   think we should unify it into a single helper method (where we check
   all counters).
 - The initialization of stats_init is repeated many times.  Isn't it
   better to define it as a test class member and initialize it in the
   constructor?
 - `AXFRSuccess` test: this makes me wonder whether we should count
   "forwarded" queries (and/or requests), although it'd be beyond the
   scope of this ticket.
 - It would also be good if we simplify and unify the verbose pattern
   seen in (e.g.) `queryCounterUDPNormal`.
 - I've checked this, but is it comprehensive?  i.e., is there a
   counter that should be incremented in some scenario but not checked
   in the test?

 '''statistics_unittest.cc'''

 Like auth_srv test, it would be better if we unify same/similar patterns.

 '''Other'''

 These files are updated in the revised version.  Am I expected to
 review these?

 - src/lib/statistics/counter.h
 - src/lib/statistics/counter_dict.h
 - tests/lettuce/configurations/example.org.inmem.config
 - tests/lettuce/features/queries.feature
 - tests/lettuce/features/terrain/bind10_control.py
 - tests/system/bindctl/tests.sh

-- 
Ticket URL: <http://bind10.isc.org/ticket/2157#comment:38>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development