BIND 10 #2218: update InMemoryZoneFinder::findNSEC3 using memory-efficient version

[BIND 10 Development]

#2218: update InMemoryZoneFinder::findNSEC3 using memory-efficient version
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20121009
  medium                             |            Resolution:
                  Component:  data   |             Sensitive:  0
  source                             |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  5
            Defect Severity:  N/A    |           Total Hours:  10.75
Feature Depending on Ticket:         |
  scalable inmemory                  |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:22 muks]:

 > > But, anyway, at the moment this won't cause any difference in
 > > observable server behavior as we only support complete, full loading
 > > of zones.
 > >
 > > So, for the purpose of this ticket I'm okay with the current code.
 > > We'll need a separate cleanup ticket though.
 >
 > Let's clean it up when we support incremental signing. We will notice it
 anyway then.

 BTW I've created a ticket: #2295.

 > > > Let's keep this for now as the worst thing it does is check more. :)
 I want to finish up the other loose ends and merge this.
 > >
 > > Okay, can you open a ticket for that?
 >
 > I've fixed it in branch trac2218_3. Please review it and I'll close this
 bug after that.

 In the branch you seem to have updated addZoneDataNSEC3() while I
 actually mentioned addZoneData().  In fact, the same sense of comments
 would apply to both, so the changes to addZoneDataNSEC3() are fine,
 but we need to handle addZoneData().

 But before going further, I'd like to point out that more
 fundamentally: Do we need to implement the loading
 logic in the test again?  Almost everything in addZoneDataNSEC3() and
 addZoneData() seem to be more of less a copy of the adding/loading
 logic in memory_client.cc.  Can't we use the existing
 InMemoryClient::add() interface?

-- 
Ticket URL: <http://bind10.isc.org/ticket/2218#comment:23>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development