BIND 10 #2268: some cleanups for in-memory zone load

BIND 10 Development do-not-reply at isc.org
Wed Oct 3 11:08:26 UTC 2012


#2268: some cleanups for in-memory zone load
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  UnAssigned
  jinmei                             |                Status:  assigned
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20121009
  medium                             |            Resolution:
                  Component:  data   |             Sensitive:  0
  source                             |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  5
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by muks):

 * owner:  muks => UnAssigned


Comment:

 Up for review.

 A few notes:

 * This branch also contains the ZoneFinder test cleanup mentioned in #2218
 (see comments 23 and 25) as it depends on the refactored code.
 * For the sorting, tests insert RRTypes like A, AAAA and MX out of order
 and check that they are returned in order.
 * I have not added direct tests for `ZoneDataUpdater` as everything which
 happens inside it is tested thoroughly from `InMemoryClient`'s testcode.
 Changing all those tests to directly work with `ZoneData` would be a lot
 of work (outside points for this bug) as I know it took a long time to
 write `InMemoryClient`'s tests to handle every validation case. I don't
 think we need such excess testing as `InMemoryClient` already covers it,
 but if the reviewer says we do, let's create another bug for it.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2268#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list