BIND 10 #2060: ZoneFinder::Context::getAtOrigin

BIND 10 Development do-not-reply at isc.org
Wed Oct 3 16:25:38 UTC 2012


#2060: ZoneFinder::Context::getAtOrigin
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20121009
  medium                             |            Resolution:
                  Component:  data   |             Sensitive:  0
  source                             |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  5
            Defect Severity:  N/A    |           Total Hours:  0.55
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Thanks for the review.

 Replying to [comment:8 vorner]:

 > Hello
 >
 > Replying to [comment:5 jinmei]:
 > > Actually the only related change is the first commit (d73842e).
 >
 > Which ticket is it that'll actually use this new method? I think we
 could
 > switch to it before writing the specialized versions.

 It's expected to be done in #2284.

 > > I hope the additional review load for the second commit is acceptable,
 > > but if not, I'm okay with deferring it to #1767.
 >
 > That's OK. But I think the `getFinder` and `getAllRRsets` comments need
 to
 > clarify the ownership of the pointer (that it is preserved in the
 context, not
 > passed onto the caller).
 >
 > Other than that, it looks OK, so after documenting it, please merge.

 Okay, I've updated the doxygen comments.  Hoping the new text is okay,
 I'm going to merge the branch and close the ticket.  If you don't
 think the doc isn't good or something different from what you intended
 please raise it.  If it's minor we'll correct it on master; otherwise
 we can create a new followup ticket.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2060#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list