BIND 10 #1870: install complete header files

[BIND 10 Development]

#1870: install complete header files
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:         |             Milestone:
  defect                             |  Sprint-20121009
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:  build  |           Sub-Project:  DNS
  system                             |  Estimated Difficulty:  5
                   Keywords:         |           Total Hours:  0
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Thanks for the review.

 Replying to [comment:12 vorner]:

 >  * `if test "${bind10_inc_path}" ; then` ‒ should there be some kind of
 `test -z` or something?

 Good catch, I believe I fixed it.

 >  * When I run the configure in examples, it checks for boost twice:

 Ah, thanks for the careful check.  I actually didn't have to call
 AX_BOOST_INCLUDE explicitly because AC_REQUIRE does it internally.
 Removed the extra call, and it should solve this.

 > Also, the configure doesn't seem to work for me :-(.

 > {{{
 > ./configure --with-
 bind10-include=/home/vorner/testing/bind10/include/bind10-devel/ --with-
 bind10-include=/home/vorner/testing/bind10/lib/
 >
 > checking util/buffer.h usability... no
 > checking util/buffer.h presence... no
 > checking for util/buffer.h... no
 > configure: error: Missing a commonly used BIND 10 header files
 >     1 vorner at hydra ~/work/bind10/examples (review/headers 18) 4%
 > $ ls /home/vorner/testing/bind10/include/bind10-devel/
 > dns  exceptions  util
 > 12:25 vorner at hydra ~/work/bind10/examples (review/headers 18) 4%
 > $ ls /home/vorner/testing/bind10/include/bind10-devel/util/
 > buffer.h
 > 12:25 vorner at hydra ~/work/bind10/examples (review/headers 18) 4%
 > }}}
 >
 > Is it something I do wrong, or is the script broken? (please, don't get
 confused by my unusual prompt there)

 Hmm, strange.  Did you install this branch under
 /home/vorner/testing/bind10/?  util/buffer.h is one of the missing
 header files that are not installed in the current master, so you need
 to first build and install this branch.  Explicit manual check may
 also help: is there buffer.h in
 /home/vorner/testing/bind10/include/bind10-devel/util?

 If the answer to both is yes, I have no idea why it failed.  Can you
 show your config.log?

 > Also, I noticed most of our changelogs are either in past tense or third
 form. Your looks like in imperative. Not that it would be a problem, but
 maybe just for consistency, it could be unified.

 You mean "Make sure..." sounds like imperative (and dramatically
 you're right)?

 {{{
 484.?   [bug]*          jinmei
         Make sure all public header files for libb10-dns++ are installed.
 ...
 }}}

 If that's the concern, how about this?

 {{{
 484.?   [bug]*          jinmei
         All public header files for libb10-dns++ are now installed.
         Template configure.ac and utility AC macros for external projects
         using the library is provided under the "examples" directory.
         The src/bin/host was moved as part of the examples (and not
         installed with other BIND 10 programs any more).
         (Trac #1870, git TBD)
 }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/1870#comment:13>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development