BIND 10 #2275: work on valgrind backlog
BIND 10 Development
do-not-reply at isc.org
Thu Oct 4 15:36:38 UTC 2012
#2275: work on valgrind backlog
-------------------------------------+-------------------------------------
Reporter: jreed | Owner: UnAssigned
Type: | Status: reviewing
defect | Milestone:
Priority: | Sprint-20121009
medium | Resolution:
Component: | Sensitive: 0
Unclassified | Sub-Project: Core
Keywords: | Estimated Difficulty: 5
Defect Severity: N/A | Total Hours: 0
Feature Depending on Ticket: |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by jelte):
* owner: jelte => UnAssigned
* status: assigned => reviewing
Comment:
Ready for review.
My system's valgrind does not detect all cases newer versions do, but
still, these changes reduced the suppressions file I get from 8867 lines
(608 suppressions) to 224 lines (8 suppressions)
Most of the changes are pretty straightforward I think.
A couple of the memsets could technically be a little more specific (for
instance take into account which data we know we will write, and only
blank the rest), but it seemed more prudent to initialize the entire thing
first.
For most directories in src/lib the unittests *should* now pass with
valgrind without any suppressions. A few notable exceptions are
- any sets that contain death tests (valgrind goes bonkers on those, and
probably rightfully so)
- lib/resolver tests (need some serious rework of either the resolver or
the test setup due to classes that are supposed to delete themselves)
--
Ticket URL: <http://bind10.isc.org/ticket/2275#comment:3>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list