BIND 10 #2292: eliminate const_cast from domaintree.h

BIND 10 Development do-not-reply at isc.org
Sun Oct 7 15:45:57 UTC 2012


#2292: eliminate const_cast from domaintree.h
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:         |             Milestone:
  defect                             |  Sprint-20121009
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:  data   |           Sub-Project:  DNS
  source                             |  Estimated Difficulty:  4
                   Keywords:         |           Total Hours:  0
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => jinmei


Comment:

 Hello

 Replying to [comment:7 jinmei]:
 > Actually, I thought this was misuse of the read-only interface and
 > wanted to correct at this opportunity.  If we want to possibly modify
 > a found node, we should use insert().

 Actually, I didn't know such a wide scope was meant by the ticket (so I
 didn't
 even look how much the method is used). It seems to be possible when
 changing
 stuff that far away.

 I hope the current changes are not problematic (I removed the add method
 of the
 in-memory data source). Also, the history isn't really clean now (the
 template
 parameters were introduced and later removed in this branch). Should I try
 to
 rebuild the history in some cleaner way? It shouldn't be that much work I
 think, if we care about how the history looks like.

 With regards

-- 
Ticket URL: <http://bind10.isc.org/ticket/2292#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list