BIND 10 #2275: work on valgrind backlog
BIND 10 Development
do-not-reply at isc.org
Mon Oct 8 08:17:49 UTC 2012
#2275: work on valgrind backlog
-------------------------------------+-------------------------------------
Reporter: jreed | Owner: jinmei
Type: | Status: reviewing
defect | Milestone:
Priority: | Sprint-20121009
medium | Resolution:
Component: | Sensitive: 0
Unclassified | Sub-Project: Core
Keywords: | Estimated Difficulty: 5
Defect Severity: N/A | Total Hours: 0
Feature Depending on Ticket: |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by jinmei):
Replying to [comment:10 jelte]:
> well, it would always hit the check and exception, but due to the
initialized memory, it was essentially random which of the two parts of
the if-check it would hit (so yeah, it was buggy, and certainly not doing
what it intended, but it would never visibly fail)
Right.
> > The previous version used the length (strlen) of path_, so sun_path
> > could actually be non-nul terminated even if path_ is short enough.
> > (another reason why we should generally avoid such low-level APIs).
> >
> > I believe with this change valgrind stops complaining about this.
>
> ah, doh, of course.
Looks good, please merge.
--
Ticket URL: <http://bind10.isc.org/ticket/2275#comment:11>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list