BIND 10 #2237: Pool/Lease Configuration - IPv4

[BIND 10 Development]

#2237: Pool/Lease Configuration - IPv4
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  tomek
  stephen                            |                Status:  reviewing
                       Type:  task   |             Milestone:  Sprint-
                   Priority:         |  DHCP-20121018
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  dhcpconf                           |           Sub-Project:  DHCP
                   Keywords:         |  Estimated Difficulty:  0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => tomek


Comment:

 Reviewed commit 5e39872cc6dc260c91596ee31f1601dbf53de503

 >> '''src/lib/dhcp/addr_utilities.cc'''[[BR]]
 >> The .h file doesn't seem to have been updated with the function
 definitions.
 > That's by design. Those new functions are private. The external
 interface is done via generic functions that accept both protocol
 families. I don't want anyone to call v4 and v6 functions directly as they
 lack sanity checks. Those sanity checks are done in generic, public
 versions.
 In that case, that should be either made static or put within the
 anonymous namespace in the file (so that they can't be called from outside
 the file).

 Once that is corrected, the code can be merged: I don't need to see it
 again.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2237#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development