BIND 10 #2244: remove ddns component, but boss still keeps trying to start it

BIND 10 Development do-not-reply at isc.org
Tue Oct 9 18:20:45 UTC 2012


#2244: remove ddns component, but boss still keeps trying to start it
-------------------------------------+-------------------------------------
                   Reporter:  jreed  |                 Owner:  jinmei
                       Type:         |                Status:  reviewing
  defect                             |             Milestone:
                   Priority:         |  Sprint-20121023
  medium                             |            Resolution:
                  Component:  Boss   |             Sensitive:  0
  of BIND                            |           Sub-Project:  Core
                   Keywords:         |  Estimated Difficulty:  6
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:10 vorner]:

 > I indeed did mean the older (shell and perl based) ones. And I think it
 is introduced in this branch, because:
 >  * 93e596c completes fine, without a failure. Other branches I reviewed
 recently were OK too.
 >  * This branch fails with the same set of errors reliably, every time (4
 of 4
 >    attempts it failed, there was even a reboot in between, etc).
 >  * The first failing scenario is about restarting, the others are just
 follow-ups:

 Okay, you were right.  I've found a bug that caused this problem and
 fixed it.  We should have been able to notice that sooner if we had
 unit tests for Bob.reap_children().  We could add one within this
 ticket, but I'd rather suggest leaving it to a separate ticket, and in
 a larger framework: despite its importance the Bob class and
 bind10_src.py.in in general are tested only very poorly.  I suggest
 refactoring it so the core logic will be more independent from
 system-dependent things like process scheduling, also probably making
 the Bob class more concise, and providing more tests for them.
 Providing tests for reap_children() would be part of this larger task.

 If this makes sense, and the latest branch passes the test (which I'm
 quite sure does), I'll create the followup tickets and close this one.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2244#comment:11>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list