BIND 10 #2223: Update tests for code disabled in rrsetsCheck()

[BIND 10 Development]

#2223: Update tests for code disabled in rrsetsCheck()
-------------------------------------+-------------------------------------
                   Reporter:  muks   |                 Owner:  jinmei
                       Type:         |                Status:  reviewing
  defect                             |             Milestone:
                   Priority:         |  Sprint-20121023
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  libdns++                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  4
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:8 jelte]:
 > True, it would incorrectly fail on case, which doesn't actually happen.
 >
 > But as noted on jabber, and in keeping with the original intent, in that
 case it can be done even easier, by just looping over the iterators and
 counting the number of rrsets, counting signed rrsets twice.
 >
 > This makes the replacement even smaller

 Hmm, does this version regain the very original (pre 'if 0') behavior?
 It seems it doesn't compare the content of RRSIGs, so I suspect it
 passes the case like this:

 Actual iterator: RRset-A (containing RRSIG RRset-A'), RRset-B
 Expected iterator: RRset-A,  RRSIG RRset-A'', RRset-B

 If I remember it correctly, in the pre 'if 0' version, "actual
 iterator" separated RRset-A and contained RRSIG RRset, and it's
 compared to RRset-A'' in the for loop.  So we should have been able to
 detect these two sets are not equal.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2223#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development