BIND 10 #2268: some cleanups for in-memory zone load

[BIND 10 Development]

#2268: some cleanups for in-memory zone load
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20121023
  medium                             |            Resolution:
                  Component:  data   |             Sensitive:  0
  source                             |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  5
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 The latest branch now looks pretty good.  I have a few more points though:

 - `MockIterator` variants have many duplicates.  Obviously, this
   approach doesn't scale as we add more tests like these.  I'd combine
   them, e.g., by passing the expected sequence of RRsets as
   vector<ConstRRsetPtr> or something and just iterate over them
   returning one by one in getNextRRset().
 - I believe addOutOfZoneThrows test is still needed.  Consider the
   case we instantiate `ZoneDataUpdater` with zone data for example.org
   and call add() with a.example.com/A.
 - same for addNullRRsetThrows and addEmptyRRsetThrows.
 - `addOutOfZoneThrows` etc should now better belong to something like
   "loader (or updater) tests", although it may be a subject of the
   deferred ticket.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2268#comment:14>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development