BIND 10 #2223: Update tests for code disabled in rrsetsCheck()

[BIND 10 Development]

#2223: Update tests for code disabled in rrsetsCheck()
-------------------------------------+-------------------------------------
                   Reporter:  muks   |                 Owner:  jinmei
                       Type:         |                Status:  reviewing
  defect                             |             Milestone:
                   Priority:         |  Sprint-20121023
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  libdns++                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  4
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 In terms of functionality this version looks okay.  I have a few more
 minor comments.

 - pullSigs(): do we need to call toText() for the RRSIG?  I thought
   `RRset::toText()` now includes both the main and (if any) RRSIGs.
 - s/checkRRset()/rrsetCheck()/?
 {{{#!cpp
     // separate RRsets (checkRRset() later does not check signatures
 }}}
 - very minor point, but I suggest placing expected_rrsets first:
 {{{#!cpp
     std::vector<isc::dns::ConstRRsetPtr> actual_rrsets, expected_rrsets;
 }}}
   as "expectedXXX" are generally placed first in this function (and
   that's gtest's EXPECT_xx convention).

 - this comment doesn't seem to match the actual code any more:
 {{{#!cpp
         // search).  Since the actual set is guaranteed to be unique, we
 can
         // detect it if the expected data has a duplicate by the
 match/size
         // checks at the end of the function.
 }}}
   I guess this should now be something like "By guaranteeing the
   actual set is unique and the size of both vectors are the same,
   we can conclude the two sets are identical after this loop".

-- 
Ticket URL: <http://bind10.isc.org/ticket/2223#comment:12>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development