BIND 10 #2223: Update tests for code disabled in rrsetsCheck()
BIND 10 Development
do-not-reply at isc.org
Tue Oct 16 17:47:30 UTC 2012
#2223: Update tests for code disabled in rrsetsCheck()
-------------------------------------+-------------------------------------
Reporter: muks | Owner: jinmei
Type: | Status: reviewing
defect | Milestone:
Priority: | Sprint-20121023
medium | Resolution:
Component: | Sensitive: 0
libdns++ | Sub-Project: DNS
Keywords: | Estimated Difficulty: 4
Defect Severity: N/A | Total Hours: 0
Feature Depending on Ticket: |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by jinmei):
Replying to [comment:14 jelte]:
> > - pullSigs(): do we need to call toText() for the RRSIG? I thought
> > `RRset::toText()` now includes both the main and (if any) RRSIGs.
>
> the default toText() implementation certainly does not
Hmm, that seems to be different from the `TreeNodeRRset`
specialization. We should be consistent, but that should go to a
separate task.
While that could cause some confusion when this test fails, I think
it's okay for now since it only happens when test fails and it's used
in SCOPED_TRACE().
I've made one last small editorial fix. With that please merge.
--
Ticket URL: <http://bind10.isc.org/ticket/2223#comment:15>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list