BIND 10 #2360: RRset::toText() should be consistent about included RRSIG

[BIND 10 Development]

#2360: RRset::toText() should be consistent about included RRSIG
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  UnAssigned
  jinmei                             |                Status:  new
                       Type:         |             Milestone:  Next-Sprint-
  defect                             |  Proposed
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:         |           Sub-Project:  DNS
  libdns++                           |  Estimated Difficulty:  0
                   Keywords:         |           Total Hours:  0
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Description changed by jinmei:

Old description:

> If I understand the code correctly, `AbstractRRset::toText()` and
> `TreeNodeRRset::toText()` show different behaviors when the RRset
> includes an RRSIG in it: The former doesn't print the RRSIG while the
> latter does.
>
> Obviously this must be consistent.
>
> The fix is easy, but the main question is which behavior.  I
> personally suggest the `TreeNodeRRset' approach.  It's also consistent
> with the `toWire()` behavior, and IMO it's more intuitive for the
> concept of "signed RRset".  Optionally we might provide an option to
> control the behavior (or provide a different version of toText()), on
> which I don't have a specific opinion yet.
>
> Don't forget updating the documentation to clarify this point (and
> also for toWire()), too.

New description:

 If I understand the code correctly, `AbstractRRset::toText()` and
 `TreeNodeRRset::toText()` show different behaviors when the RRset
 includes an RRSIG in it: The former doesn't print the RRSIG while the
 latter does.

 Obviously this must be consistent.

 The fix is easy, but the main question is which behavior.  I
 personally suggest the `TreeNodeRRset` approach.  It's also consistent
 with the `toWire()` behavior, and IMO it's more intuitive for the
 concept of "signed RRset".  Optionally we might provide an option to
 control the behavior (or provide a different version of toText()), on
 which I don't have a specific opinion yet.

 Don't forget updating the documentation to clarify this point (and
 also for toWire()), too.

--

-- 
Ticket URL: <http://bind10.isc.org/ticket/2360#comment:2>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development