BIND 10 #2332: define and implement wrapper interface for conditional variables
BIND 10 Development
do-not-reply at isc.org
Wed Oct 17 16:08:00 UTC 2012
#2332: define and implement wrapper interface for conditional variables
-------------------------------------+-------------------------------------
Reporter: | Owner: jinmei
jinmei | Status: reviewing
Type: task | Milestone:
Priority: | Sprint-20121023
medium | Resolution:
Component: | Sensitive: 0
b10-auth | Sub-Project: DNS
Keywords: | Estimated Difficulty: 5
Defect Severity: N/A | Total Hours: 0
Feature Depending on Ticket: |
background zone loading |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by jinmei):
Replying to [comment:23 vorner]:
> > Based on your comment I guess we are talking about the same thing.
> > So, what would you want it to be? changing it to an assertion?
> > Or add a comment like this?
>
> I think assertion could be better here. Or throwing another kind of
exception
> (like Unexpected), because InvalidOperation might suggest wrong usage
from
> outside.
Okay, I changed it to assert().
> > BTW, please also confirm (or reject) the following part of proposal:
> >
> > {{{
> > If the content of the branch is okay, I'd like to propose changing the
> > file name "lock.h/cc" to something like sync.h/cc or
> > synchronization.h/cc.
> > }}}
>
> Ah, sorry I forgot about that. Yes, it looks OK.
This is done, too. I renamed them thread/sync.{h,cc} and made trivial
adjustments.
Now it's okay for merge?
--
Ticket URL: <http://bind10.isc.org/ticket/2332#comment:24>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list