BIND 10 #2366: FATAL [b10-resolver.resolver] RESOLVER_FAILED - Missing logger placeholder in message

[BIND 10 Development]

#2366: FATAL [b10-resolver.resolver] RESOLVER_FAILED -  Missing logger placeholder
in message
---------------------------------+-----------------------------------------
            Reporter:  jreed     |                        Owner:
                Type:  defect    |                       Status:  new
            Priority:  medium    |                    Milestone:  New Tasks
           Component:  resolver  |                     Keywords:
           Sensitive:  0         |              Defect Severity:  N/A
         Sub-Project:  DNS       |  Feature Depending on Ticket:
Estimated Difficulty:  0         |          Add Hours to Ticket:  0
         Total Hours:  0         |                    Internal?:  0
---------------------------------+-----------------------------------------
 I tried a CH class query against the resolver and it crashed the
 b10-resolver:

 {{{
 2012-10-18 07:02:54.930 FATAL [b10-resolver.resolver] RESOLVER_FAILED
 resolver f
 ailed, reason: Missing logger placeholder in message:
 RESOLVER_NON_IN_PACKET non
 -IN class request received, returning REFUSED message
 }}}

 I am using --enable-logger-checks. A fix is easy:

 {{{
 diff --git a/src/bin/resolver/resolver_messages.mes
 b/src/bin/resolver/resolver_messages.mes
 index 34a97ae..214519b 100644
 --- a/src/bin/resolver/resolver_messages.mes
 +++ b/src/bin/resolver/resolver_messages.mes
 @@ -108,7 +108,7 @@ This error is issued when a resolver configuration
 update has specified
  a negative retry count: only zero or positive values are valid.  The
  configuration update was abandoned and the parameters were not changed.

 -% RESOLVER_NON_IN_PACKET non-IN class request received, returning REFUSED
 message
 +% RESOLVER_NON_IN_PACKET non-IN class (%1) request received, returning
 REFUSED message
  This debug message is issued when resolver has received a DNS packet that
  was not IN (Internet) class.  The resolver cannot handle such packets,
  so is returning a REFUSED response to the sender.
 }}}

 May I commit this?

-- 
Ticket URL: <http://bind10.isc.org/ticket/2366>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development