BIND 10 #2316: Extend "Subnet" with OptionCollection structure

[BIND 10 Development]

#2316: Extend "Subnet" with OptionCollection structure
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  marcin
  marcin                             |                Status:  reviewing
                       Type:  task   |             Milestone:  Sprint-
                   Priority:         |  DHCP-20121018
  medium                             |            Resolution:
                  Component:  dhcp   |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DHCP
            Defect Severity:  N/A    |  Estimated Difficulty:  0
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => marcin


Comment:

 Reviewed commit 9bb3d27efdf09dd2e429086767cdee275f3df115

 >> '''src/lib/dhcp/subnet.cc'''
 >> Subnet{4,6}::validateOption(): as these methods don't alter the
 shared_ptr (nor the unerlying reference count), can the option argument be
 declared "const"?
 >Yes, it should be const. Fixed.
 The change made the method "const", which I overlooked.  However the
 suggestion was that the argument itself can be made "const". (In fact, the
 argument can also be passed by reference - made "const !OptionPtr&" - to
 avoid the overhead of an increment/decrement of the reference count.)

 If you agree, please make the change. (I do not need to see the ticket
 again if you do.)  It can now be merged.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2316#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development