BIND 10 #2304: implement OptionDefinition class

BIND 10 Development do-not-reply at isc.org
Fri Oct 19 11:05:24 UTC 2012


#2304: implement OptionDefinition class
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  marcin
  marcin                             |                Status:  reviewing
                       Type:  task   |             Milestone:  Sprint-
                   Priority:  high   |  DHCP-20121018
                  Component:  dhcp   |            Resolution:
                   Keywords:         |             Sensitive:  0
            Defect Severity:  N/A    |           Sub-Project:  DHCP
Feature Depending on Ticket:         |  Estimated Difficulty:  0
        Add Hours to Ticket:  0      |           Total Hours:  0
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => marcin


Comment:

 Reviewed commit b617d1a26e4e4fd536b37848b1dd39ff40f5213b

 > I was not guided by the coding standard here. Coding standard does not
 prohibit putting the explicit values AFAIK. I wanted to have the easy way
 to check that supplied enum value is within the range of expected values
 (using < operator). Although in most cases enum values will be assigned
 incrementally by the compiler if they are omitted in enum's declaration, I
 am not fully convinced that it is always the case. If I hadn't put
 explicit values I would have had to do checks on every supplied value
 against all defined enums to make sure that the value is correct.
 In fact the standard does say that enum values start at 0 and that the
 value each entry without a value is one more than the value of the
 preceding one.

 All OK, please merge.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2304#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list