BIND 10 #2142: Design and Creation Script for SQL Lease Database

[BIND 10 Development]

#2142: Design and Creation Script for SQL Lease Database
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  stephen
  stephen                            |                Status:  reviewing
                       Type:  task   |             Milestone:  Sprint-
                   Priority:         |  DHCP-20121101
  medium                             |            Resolution:
                  Component:  dhcp   |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DHCP
            Defect Severity:  N/A    |  Estimated Difficulty:  0
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by stephen):

 >>> There should be a comment about portability (this was explicitly
 requested). It should be pointed that the schema can be used as is, with
 the exception of engine specification, which is likely MySQL specific.
 >> Added.
 > Speaking about the portability, perhaps this script could be renamed to
 not explicitly have mysql in its name? We could have a generic script
 name. It already states in the script that it is for MySQL. That would
 give more "portable" feel. It's not a strong suggestion, but something you
 may consider.
 I've left it as ".mysql" for now.  Two reasons:
 * The script is only temporary - in the longer-term, I see it being
 included in the "b10-dbutil" utility.
 * I also think that it is possible that although the code will work with
 multiple databases, the actual schema will be slightly different.

 >>> We should consider adding "CREATE database Kea;" at the beginning.
 >> I'd rather not do this - there is always the possibility that the
 physical database is shared between two independent servers: in this case,
 it could be that two databases are used.
 > Disagree for two reasons. What you say is possible, but rather unlikely.
 It is much more likely that the user will run the script and then get
 confused about lots of errors, because no database was created. The second
 point is that CREATE database does not remove existing database, if it
 exists.
 At the moment, the script is also required to create the test database.
 Adding a "CREATE DATABASE" line will mean that some form of shell script
 is required to parameterise the database name.

 > The ticket is back with you. Regardless if you choose to accept or
 reject my comments, I don't see a need to discuss them further. Please do
 as you think is right and merge the ticket. I don't need to review it
 again.
 Events have overtaken this ticket, with the script being modified as part
 of #2342.  This branch will not be merged: instead, the two files of this
 ticket have been added to #2342, and will be merged when that ticket is
 merged.

 This ticket will be closed when #2342 is closed.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2142#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development