BIND 10 #2236: Add a --enable-debug configure flag
BIND 10 Development
do-not-reply at isc.org
Tue Oct 23 13:13:45 UTC 2012
#2236: Add a --enable-debug configure flag
-------------------------------------+-------------------------------------
Reporter: | Owner: muks
vorner | Status: reviewing
Type: task | Milestone:
Priority: low | Sprint-20121023
Component: | Resolution:
Unclassified | Sensitive: 0
Keywords: | Sub-Project: DNS
Defect Severity: N/A | Estimated Difficulty: 3
Feature Depending on Ticket: | Total Hours: 0
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by vorner):
* owner: vorner => muks
Comment:
Hello
Replying to [comment:9 muks]:
> In my understanding, the choice of include style has nothing to do with
whether the header is local or not.
>
> * `<>` replaces what's inside the delimiters by something that is
implementation dependent.. it could be a file, or something else
> * `""` replaces what's inside the delimiters by a file (where it is
found is implementation dependent.. usually -I, system directories, etc.)
Hmm, what I thought was that both replace by a file and both are
implementation
dependant. But in practice, `""` first searches the local directory, then
-I
paths, while `<>` does the -I paths only. At least from how I saw them
used
across projects, if something is included by `""`, I tend to expect that
file/path is to be located relatively from the file it is included into.
> I spoke to Jinmei about it, and he said that we can defer it to when we
do a cleanup of the entire tree based on what style we choose.
OK.
This `TODO` is left in the code:
{{{#!c++
#ifdef ENABLE_DEBUG
// TODO: Distinguish if debug mode is enabled in compilation.
}}}
Also, do you know the practical difference between `PTHREAD_MUTEX_NORMAL`
and
`PTHREAD_MUTEX_DEFAULT`? It looks like the `PTHREAD_MUTEX_DEFAULT` leaves
it up
to the compiler to decide if to use `PTHREAD_MUTEX_NORMAL` or
`PTHREAD_MUTEX_ERRORCHECK`. If that's your impression too, maybe it would
be
better to explicitly ask for the `PTHREAD_MUTEX_NORMAL`?
Thanks
--
Ticket URL: <http://bind10.isc.org/ticket/2236#comment:11>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list