BIND 10 #2211: update the data source reconfigure command so it uses thread

BIND 10 Development do-not-reply at isc.org
Tue Oct 23 17:24:22 UTC 2012


#2211: update the data source reconfigure command so it uses thread
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20121106
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  b10-auth                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  6
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
  background zone loading            |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:20 vorner]:

 > > I really don't understand it if you mean this one is "extreme" or
 > > complicated:
 [...]
 > > I don't mind changing the former to the latter, but since I may simply
 > > misunderstand you, I still didn't change that.
 >
 > Whenever there is a block that is neither a function or if or a cycle, I
 find it unusual. But let it be.

 Ah, okay, I finally understood it.  I don't like such blocks either.
 On the other hand, in these cases I think it'd good to be somehow
 explicit about the lifetime of the lock.  So I removed the extra block
 and added some comments.

 > > Okay, changed.  I'll create a separate topic for this issue.
 >
 > Can you change the LOG_ERROR to LOG_FATAL there, if we are going to
 abort for that reason?

 Done.

 > Otherwise the code looks good, so please merge. Or you might want to
 wait a
 > short while, until my local test run finishes, but I don't expect it to
 break,
 > there were no changes that should cause that.

 Assuming the first change is okay, I'll merge the branch once #2210 is
 merged.

 Thanks,

-- 
Ticket URL: <http://bind10.isc.org/ticket/2211#comment:21>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list