BIND 10 #2297: Fix isc-sysinfo free memory, uptime, smp output

BIND 10 Development do-not-reply at isc.org
Thu Oct 25 00:29:47 UTC 2012


#2297: Fix isc-sysinfo free memory, uptime, smp output
-------------------------------------+-------------------------------------
                   Reporter:  jreed  |                 Owner:  jinmei
                       Type:         |                Status:  accepted
  defect                             |             Milestone:
                   Priority:  low    |  Sprint-20121106
                  Component:         |            Resolution:
  sysinfo                            |             Sensitive:  0
                   Keywords:         |           Sub-Project:  Core
            Defect Severity:  N/A    |  Estimated Difficulty:  4
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 trac2297 is ready for review.

 First note: I made a couple of unrelated changes:
 - introduce run_sysinfo script so we can run it in the build tree
 - removed the call to isc.util.process.rename().  see the commit log.

 Regarding the support of SMP in kernel, the fix is a kind of ugly
 hack (7d777ce), but I couldn't come up with a cleaner way.

 Regarding the negative memory, I don't know the intent of the original
 code, but "'physical memory' - 'active VM memory'" shouldn't be
 valid calculation anyway.  Showing the size of free-list may not be
 exactly what we want to show, but it seems to be closer to e.g. what
 top() reports.  I applied the same change to the OpenBSD version.

 Proposed changelog:
 {{{
 496.?   [bug]           jinmei
         Fixed several issues in isc-sysinfo:
         - make sure it doesn't report a negative value for free memory
           size (this happened on FreeBSD, but can possibly occur on other
           BSD variants)
         - correctly identifies the SMP support in kernel on FreeBSD
         - print more human readable uptime as well as the time in seconds
         (Trac #2297, git TBD)
 }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/2297#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list