BIND 10 #2208: Revise InMemoryClient and ConfigurableClientList::configure() using ZoneTableSegment

BIND 10 Development do-not-reply at isc.org
Thu Oct 25 00:56:40 UTC 2012


#2208: Revise InMemoryClient and ConfigurableClientList::configure() using
ZoneTableSegment
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  muks
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20121106
  medium                             |            Resolution:
                  Component:  data   |             Sensitive:  0
  source                             |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  5
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
  background zone loading            |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by muks):

 Replying to [comment:12 jelte]:
 >
 > awesome :)
 >
 > One final small thing, It looks like the rrclass arguments can be const
 references. But with that it can be merged

 I wrote part of such a change before giving the bug back to you :) .. and
 then reset my tree because there is no consistency in the code about it.
 `RRClass` are references in some places, and not in others. I just
 followed the nearest convention. See `createSQLite3Client()` on to
 `DatabaseClient()`, stuff in `isc::datasrc::memory` such as `RdataSet`,
 `ZoneData`, `InMemoryClient`, etc.

 Now the code which is modified by this branch (`ZoneTable` and
 `ZoneTableSegment::create()`) has been updated to use const references
 instead. `ZoneTable` keeps a `const` copy.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2208#comment:13>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list