BIND 10 #2357: Use of reserved identifiers
BIND 10 Development
do-not-reply at isc.org
Thu Oct 25 16:28:11 UTC 2012
#2357: Use of reserved identifiers
-------------------------------------+-------------------------------------
Reporter: | Owner: muks
vorner | Status: reviewing
Type: | Milestone:
defect | Sprint-20121106
Priority: | Resolution:
medium | Sensitive: 0
Component: | Sub-Project: Core
Unclassified | Estimated Difficulty: 3
Keywords: | Total Hours: 0
Defect Severity: N/A |
Feature Depending on Ticket: |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by jelte):
* owner: jelte => muks
Comment:
what has been changed all looks good, and a quick clean build + tests
succeeded.
I have pushed a few additional changes:
A doxygen comment in the message builder wasn't updated, for which i
pushed a small fix. I also updated the rdataclass.h generator (which
included __<name> too).
(both of these in commit 1)
In second commit i just cleaned up a few #endif comments; looks like the
script didn't hit them because they didn't match the original guard name
in the first place.
With that AFAICT they are all gone; except for !PyInit!__dns in acl
wrappers, but i think the file naming (which itself starts with an
underscore) causes that name to need 2.
So your changes are OK, if mine are too (by all means check twice), this
can be merged :)
--
Ticket URL: <http://bind10.isc.org/ticket/2357#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list