BIND 10 #2297: Fix isc-sysinfo free memory, uptime, smp output
BIND 10 Development
do-not-reply at isc.org
Fri Oct 26 03:45:14 UTC 2012
#2297: Fix isc-sysinfo free memory, uptime, smp output
-------------------------------------+-------------------------------------
Reporter: jreed | Owner: jinmei
Type: | Status: reviewing
defect | Milestone:
Priority: low | Sprint-20121106
Component: | Resolution:
sysinfo | Sensitive: 0
Keywords: | Sub-Project: Core
Defect Severity: N/A | Estimated Difficulty: 4
Feature Depending on Ticket: | Total Hours: 0
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by jinmei):
Thanks for the review.
Replying to [comment:7 muks]:
> * I have pushed some minor cleanup commits. Please check them.
These look good. Thanks.
> * `make check` fails:
Oops, lazy me. I've fixed it, but just by introducing a filter for
excluding the test and specify isc-sysinfo there. I believe not doing
rename() for sysinfo is correct (mainly for reducing dependency), so
excluding it from this test is actually correct, but if it seems
controversial I'm okay with reverting this change. It's not related
to the subject of this ticket anyway.
> * Can you not use `str(t)` on `timedelta` object for the pretty
printing?
Ah, good catch. I simply overlooked it, and that should be definitely
better than reinventing the wheel. I've still left some test cases
where the result is predictable, but removed one other case due to
possible margin errors. And, in any case, now that it's a simple
library call I don't think it's not that important to check each
detailed behavior.
--
Ticket URL: <http://bind10.isc.org/ticket/2297#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list