BIND 10 #2212: support "load zone" command in the configurator thread

[BIND 10 Development]

#2212: support "load zone" command in the configurator thread
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20121106
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  b10-auth                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  5
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
  background zone loading            |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Thanks for the review.

 Replying to [comment:11 jelte]:

 > there is a compilation issue in getZoneWriter() (datasrc_clients_mgr.h);
 some compilers still need a return statement;
 >
 > I suggest adding something like
 > {{{
 >     // all cases above should either return or throw, but some compilers
 >     // still need a return statement
 >     return (boost::shared_ptr<datasrc::memory::ZoneWriter>());
 > }}}
 > at the end of getZoneWriter()

 Ah, okay, added.

 > auth_messages.mes:
 >
 > I have several small fixes for the COMMAND_ERROR log message, I'd
 propose making it this text:

 Thanks, adopted.

 > The death tests recently got an additional check (so that valgrind
 doesn't fail on them, at least if valgrind.h is available), so any code
 that does EXPECT_DEATH should include <util/unittests/check_valgrind.h>,
 and  put
 > {{{
 >     if (!isc::util::unittests::runningOnValgrind()) {
 >     }
 > }}}
 > around the EXPECT_DEATH(_IF_SUPPORTED) macros
 > (as an example, see buffer_unittest.c)

 Okay, done.

 > Oh, and FYI, maybe not entirely related to this branch (but it is about
 new code here), I plan to make a slight change in doLoadZone(); and put
 the 'default to IN if class not provided' code there, in trac2213; it is
 easier (both in code and in cycles) to do that check here, instead of in
 the code sending the thread command, as that code is dealing with a const
 element, and would need to recreate the 'entire' args variable (granted,
 it isn't that big). Other checks will go in the code i'll add in 2213, but
 it can only check, not modify data (without reconstructing 'everything').

 Hmm, I'm okay with leaving the default handling to the builder per se,
 but I'd like to avoid hardcoding the value.  The default is given in
 the spec, and the implementation should retrieve the default from it.
 But to do so, it needs to be able to access `ModuleCCSession`, and
 at least right now the builder doesn't have the access (and I'd like
 to keep it that way so that the builder is as independent as
 possible).  I know it requires the reconstructing the message, but in
 this case it's a simple name, class pair, so I think it's not a big
 overhead for the sender.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2212#comment:12>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development