BIND 10 #2155: Collect query/response statistics items in Auth module

[BIND 10 Development]

#2155: Collect query/response statistics items in Auth module
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  y-aharen
  y-aharen                           |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20121106
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:         |           Sub-Project:  DNS
  b10-auth                           |  Estimated Difficulty:  5
                   Keywords:         |           Total Hours:  6.53
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => y-aharen
 * totalhours:  0 => 6.53


Comment:

 Hello

 Replying to [comment:16 y-aharen]:
 > > Could you paste the error, please? I'd be interested to know what is
 happening there, because it seems it shouldn't be happening.
 > When I removed Counters::~Counters() from statistics.h and
 statistics.cc, g++ complains:
 > {{{
 >   CXX    auth_srv.o
 > In file included from /usr/include/boost/smart_ptr/scoped_ptr.hpp:15,
 >                  from /usr/include/boost/scoped_ptr.hpp:14,
 >                  from ../../../ext/asio/asio/system_error.hpp:19,
 >                  from
 ../../../ext/asio/asio/detail/impl/throw_error.ipp:21,
 >                  from ../../../ext/asio/asio/detail/throw_error.hpp:50,
 >                  from ../../../ext/asio/asio/ip/impl/address_v4.hpp:20,
 >                  from ../../../ext/asio/asio/ip/address_v4.hpp:205,
 >                  from ../../../ext/asio/asio/ip/address.hpp:21,
 >                  from ../../../src/lib/asiolink/io_address.h:23,
 >                  from ../../../src/lib/asiolink/io_endpoint.h:26,
 >                  from ../../../src/lib/asiolink/io_message.h:28,
 >                  from ../../../src/lib/asiolink/simple_callback.h:18,
 >                  from ../../../src/lib/asiolink/asiolink.h:23,
 >                  from auth_srv.cc:19:
 > /usr/include/boost/checked_delete.hpp: In function ‘void
 boost::checked_delete(T*) [with T = isc::auth::statistics::CountersImpl]’:
 > /usr/include/boost/smart_ptr/scoped_ptr.hpp:80:   instantiated from
 ‘boost::scoped_ptr<T>::~scoped_ptr() [with T =
 isc::auth::statistics::CountersImpl]’
 > ../../../src/bin/auth/statistics.h:161:   instantiated from here
 > /usr/include/boost/checked_delete.hpp:32: error: invalid application of
 ‘sizeof’ to incomplete type ‘isc::auth::statistics::CountersImpl’
 > /usr/include/boost/checked_delete.hpp:32: error: creating array with
 negative size (‘-0x00000000000000001’)
 > }}}

 That is indeed very strange. It doesn't seem to be related at all. Anyway,
 if it helps, let's leave it this way.

 It looks OK to merge.

 Thank you

-- 
Ticket URL: <http://bind10.isc.org/ticket/2155#comment:18>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development