BIND 10 #2318: Setting option values from Configuration Manager

[BIND 10 Development]

#2318: Setting option values from Configuration Manager
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  marcin
  marcin                             |                Status:  reviewing
                       Type:  task   |             Milestone:  Sprint-
                   Priority:         |  DHCP-20121101
  medium                             |            Resolution:
                  Component:  dhcp   |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DHCP
            Defect Severity:  N/A    |  Estimated Difficulty:  0
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by tomek):

 * owner:  tomek => marcin


Comment:

 '''src/bin/dhcp6/tests/config_parser_unittest.cc''':

 '''testOption()''': There should be extra parameter that specifies if the
 extra data (presumed to be suboptions) is allowed or not. Otherwise the
 tests will pass for options that produce random trailing garbage.

 Thanks for renaming tests. I never got round to it.

 Please add one-two sentence comment for each new test. Shawn pointed out
 that tests should have descriptions. We will make those comments more
 structured eventually, but a simple commment will do for now.

 '''optionDataDefaults test''': please also check that bogus options (102,
 103 etc) are not returned.

 '''optionDataInvalidChar, optionDataUnexpectedPrefix, and
 optionDataOddLength tests''': Please update test description.

 There is no test that checks what happens when option is defined as
 global, but later redefined on subnet. Subnet option should be used in
 such scenario.

 This concludes the review. Ticket is back with you.

-- 
Ticket URL: <https://bind10.isc.org/ticket/2318#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development