BIND 10 #2369: InputSource helper class for MasterLexer
BIND 10 Development
do-not-reply at isc.org
Tue Oct 30 16:11:29 UTC 2012
#2369: InputSource helper class for MasterLexer
-------------------------------------+-------------------------------------
Reporter: | Owner: UnAssigned
jinmei | Status: reviewing
Type: task | Milestone:
Priority: | Sprint-20121106
medium | Resolution:
Component: | Sensitive: 0
libdns++ | Sub-Project: DNS
Keywords: | Estimated Difficulty: 4
Defect Severity: N/A | Total Hours: 0
Feature Depending on Ticket: |
loadzone-ng |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by muks):
* owner: muks => UnAssigned
* status: assigned => reviewing
Comment:
Up for review. Reviewers please note:
* The constructor changes above have been added.
* The buffer inside `InputSource` just grows and grows; I may be mis-
reading this ticket, so please correct me in this review if it has to be
different
* Also note the case about what happens when `saveLine()` is called in the
middle of a file, and then at the end of the file, we call `ungetAll()`.
The line number gets correctly unset, but what about the buffer position
(consider the last point about the size of the buffer).
--
Ticket URL: <http://bind10.isc.org/ticket/2369#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list