BIND 10 #2383: add dns::Name constructor to be usable from MasterLoader
BIND 10 Development
do-not-reply at isc.org
Wed Oct 31 11:59:00 UTC 2012
#2383: add dns::Name constructor to be usable from MasterLoader
-------------------------------------+-------------------------------------
Reporter: | Owner: jinmei
jinmei | Status: reviewing
Type: task | Milestone:
Priority: | Sprint-20121106
medium | Resolution:
Component: | Sensitive: 0
libdns++ | Sub-Project: DNS
Keywords: | Estimated Difficulty: 4
Defect Severity: N/A | Total Hours: 0
Feature Depending on Ticket: |
loadzone-ng |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by jelte):
* owner: jelte => jinmei
Comment:
In general it looks ok, some minor points below:
- ft_at in name.cc:130 has a comment that it is not used, but it is used
(at least in the code below)
- regarding @, should input like '@foo' be accepted (how lenient do we
want to be)? and if not, do we fail here or in the lexer? (looks like the
current implementation would drop all text after the @-sign, if it gets
here), this may also be related to requirements section 3.7.3 (soa rname
with @)
- wild idea (and totally offtopic, should maybe have though of this
earlier): perhaps we'll want to warn if the name is not absolute, but does
appear to end with the origin. This is like the second most often made
mistake in editing zone files (forgetting the ., the first being not
updating soa serial). Of course, apart from whether we want to do this in
the first place, name.cc is probably not the place to do so.
--
Ticket URL: <http://bind10.isc.org/ticket/2383#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list