BIND 10 #2160: b10-auth should clear Message at the end of request handling

[BIND 10 Development]

#2160: b10-auth should clear Message at the end of request handling
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:         |             Milestone:
  defect                             |  Sprint-20120904
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:         |           Sub-Project:  DNS
  b10-auth                           |  Estimated Difficulty:  4
                   Keywords:         |           Total Hours:  0
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:9 jelte]:
 > It would appear that processMessage() is too robust ;) I couldn't really
 come up with any way to make it throw without making some existing class
 methods virtual, so tbh I think it is not worth the trouble.

 Okay.

 > I do not think this needs a changelog message.

 Okay.

 > I did remove the one call to clear() from SyncUDPServer, but left that
 class as it was for the rest (removing the message there is nontrivial and
 indeed not really related)

 If you go this further, I'd like to create a ticket to do it.  It
 should at least unify the consistent behavior about whether to pass
 a `Message` object from the XXXServer in the first place, and if the
 conclusion is they don't pass it, revise the code.

 And, then, note it here:
 {{{#!cpp
     // Make sure the buffers are fresh
     output_buffer_->clear();
     answer_->clear(isc::dns::Message::RENDER);
 }}}
 referring to that ticket.  Otherwise it wouldn't be clear who should
 clear the message and when.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2160#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development