BIND 10 #2160: b10-auth should clear Message at the end of request handling

BIND 10 Development do-not-reply at isc.org
Tue Sep 4 12:34:41 UTC 2012


#2160: b10-auth should clear Message at the end of request handling
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:         |             Milestone:
  defect                             |  Sprint-20120904
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:         |           Sub-Project:  DNS
  b10-auth                           |  Estimated Difficulty:  4
                   Keywords:         |           Total Hours:  0
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 I created a ticket I intended (#2239).  And my suggested revised
 comment to `SyncUDPServer::handleRead` is as follows:

 {{{#!cpp
     // Make sure the buffers are fresh.  Note that we don't touch query_
     // because it's supposed to be cleared in lookup_callback_.  We should
     // eventually even remove this member variable (and remove it from
     // the lookup_callback_ interface, but until then, any callback
     // implementation should be careful that it's the responsibility of
     // the callback implementation.  See also #2239).
     output_buffer_->clear();
     answer_->clear(isc::dns::Message::RENDER);
 }}}

 If the ticket and the comment make sense to you, please merge the
 branch with the added comment.

-- 
Ticket URL: <https://bind10.isc.org/ticket/2160#comment:13>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list