BIND 10 #2082: bad ASIO update

[BIND 10 Development]

#2082: bad ASIO update
--------------------------------------------+-----------------------------
                   Reporter:  fdupont       |                 Owner:
                       Type:  defect        |                Status:  new
                   Priority:  high          |             Milestone:
                  Component:  Unclassified  |            Resolution:
                   Keywords:                |             Sensitive:  0
            Defect Severity:  Very High     |           Sub-Project:  Core
Feature Depending on Ticket:                |  Estimated Difficulty:  3
        Add Hours to Ticket:  0             |           Total Hours:  0
                  Internal?:  0             |
--------------------------------------------+-----------------------------

Comment (by fdupont):

 Replying to [comment:10 jelte]:
 > The changes jinmei mentioned were a number of ASIO_DECL additions
 (commit c32718be9f5409b6f72d98ddcd0b1ccd4c5c2293)

 => if you look at the ASIO_DECL definition you should understand that in
 the WIN32 port context I like Jinmei's changes!

 > This was reported at
 http://sourceforge.net/tracker/?func=detail&aid=3291113&group_id=122478&atid=694037
 but does not appear to have received any followup.
 >
 > I think I did the last update (from 1.4.5 to 1.4.8), however, there are
 indeed differences between our asio tree and the current officital 1.4.8
 release, and most of them are the same as your changes (352788b..3aa5044).
 I didn't do those changes manually, so it appears there is a difference
 between our 1.4.8 and upstream 1.4.8.

 => IMHO this is exactly the source of my problems so the subject of this
 ticket.

 > I also see some other changes there, are those from 1.5.X?

 => I used the last ASIO source at this time to get the fixes, now I don't
 remember if it was the stable or the development branch
 (and the box where I can perhaps find this info is on repair).

 > I confirmed jinmei's original patch does at least still apply cleanly on
 a fresh upstream 1.4.8, so we can update that one quite easily.

 => I like this idea but I can't check if it works even I expect we don't
 get problems. If you have access to a Windows 7 box with the trac816 or
 (better) trac2117 branch installed it should be easy, unfortunately my
 Windows 7 VM is on the being repaired box...
 BTW it could be a good reason to push the setup of a Windows 7 VM on the
 new test box! To come back to the ticket itself we can keep it open or
 reopen it if needed until/after this check, and for now applying your
 proposal.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2082#comment:11>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development