BIND 10 #1959: Implement perfdhcp control logic

[BIND 10 Development]

#1959: Implement perfdhcp control logic
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  marcin
  stephen                            |                Status:  reviewing
                       Type:         |             Milestone:  Sprint-
  enhancement                        |  DHCP-20120917
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:         |           Sub-Project:  DHCP
  perfdhcp                           |  Estimated Difficulty:  0
                   Keywords:         |           Total Hours:  0
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by marcin):

 Replying to [comment:19 tomek]:
 > I've found couple of new minor issues:
 >
 > '''command_options.h'''
 >
 > Some lines are too long. In DHCP4 there was a hard limit of 80 columns.
 With BIND10 we decided on a soft limit around 100 characters. Some lines
 are longer than that. There was a discussion some time ago on bind10-dev
 list, but I don't think anyone bothered to update coding guidelines.

 I cleaned this up in #1960.

 >
 > '''command_options.cc'''
 >
 > version(): I think perfdhcp should follow the same versioning scheme as
 rest of BIND10. Please include config.h and return VERSION defined in it.
 It will be much easier to maintain. Otherwise you risk having to perform
 your own releases. Believe me - you want to avoid that. :-)

 I want to avoid it. This is why I now return VERSION. Thanks.

 >
 > usage() method should print out a couple (3-4) example usages.
 Understanding which parameters are mandatory and which are optional is not
 trivial.

 This is not good candidate for this ticket. It is documentation kind of
 thing. I will include this in one of the tickets about documentation.

 >
 > '''test_control.cc'''
 > factoryOptionRequestOption6(): the buffer is defined wrong. The order is
 reversed. It should be in network byte order (0, 23, 0, 24, not 23, 0, 24,
 0). The current buffer requests options 5888 and 6144. The same mistake is
 repeated in TestControlTest.Options6.

 Fixed. Thanks.

 >
 > Ok, that's it. I have no further comments.
 >
 >

 Thanks for review.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1959#comment:22>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development