BIND 10 #1357: AXFR and AXFR-like IXFR in needs every message signed

[BIND 10 Development]

#1357: AXFR and AXFR-like IXFR in needs every message signed
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  vorner
  vorner                             |                Status:  reviewing
                       Type:         |             Milestone:
  defect                             |  Sprint-20120918
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:  xfrin  |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  5
            Defect Severity:  Low    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => vorner


Comment:

 I did a few commits to fix immediate issues I encountered, please check
 them:

 - I presume the raise Exception() in xfrin.py[.in] was not meant to stay
 there (e8a8a442cba80d9c9f2c0a7df1db981ccd195791)
 - Edited doxygen a bit (f1f86f353832e37b7987756bcba5071a5ef7101e)

 And the third commit is slightly more controversial, I added a
 Message::clear() call to Message::toWire(); if a renderer object gets
 reused it needs to be cleared every time anyway (otherwise it'll jump
 around and write at the wrong locations); We could make it so that it does
 not need the clear, but that would need more involved changes, and in case
 of truncation the renderer is cleared too (so it was a weak contract at
 best anyway). Commit c0d2f860c8125033c4433b801559b363702f231d

 (note that if we keep this, we can remove a number of renderer.clear()
 calls in other parts of the code, but I have not done so yet).


 For the rest it looks ok. Is there a ticket for the FIXME about commits?
 (i think that the intermediate commits were intentional, so all diffs are
 kept but the object is reused, this would have to be reconsidered then,
 and either the whole thing should go in one transaction or we should keep
 tabs of all Diff objects we created, and apply all of them at the end).

 Oh, and changelog looks fine too (but it's 'omitted' not 'ommited' ;))

-- 
Ticket URL: <http://bind10.isc.org/ticket/1357#comment:11>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development