BIND 10 #2231: Allow sub-second timeouts in interface manager "receive" functions

BIND 10 Development do-not-reply at isc.org
Thu Sep 13 10:55:59 UTC 2012


#2231: Allow sub-second timeouts in interface manager "receive" functions
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  marcin
  stephen                            |                Status:  reviewing
                       Type:  task   |             Milestone:  Sprint-
                   Priority:         |  DHCP-20120917
  medium                             |            Resolution:
                  Component:  dhcp   |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DHCP
            Defect Severity:  N/A    |  Estimated Difficulty:  0
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => marcin


Comment:

 Reviewed commit 250da3f615ed6d09380dc2de7e6633017530bffd

 '''src/lib/dhcp/tests/iface_mgr_unittest.cc'''[[BR]]
 receiveTimeout4/6: start_time, stop_time and duration can be declared at
 point of first use.

 receiveTimeout4/6:  When checking the duration, suggest that the upper-
 value be checked against the values suggested in my [comment:5 previous
 comment] instead of the next higher integer value of seconds, i.e. replace
 {{{
 EXPECT_LT(duration.total_seconds, 2);
 }}}
 with
 {{{
 EXPECT_LT(duration.total_microseconds, 1700000);
 }}}
 (and a similar change to the high-bound check for the sub-second timeout
 test.)

-- 
Ticket URL: <http://bind10.isc.org/ticket/2231#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list